Fix named_ss(sys, linfun, outputs) on ModelingToolkit 11.36 - #85
Merged
Conversation
MTK 11.36 removed the `inputs` field from LinearizationFunction (replaced by `inputs_getter`/`num_inputs`), breaking the precompiled-linfun `named_ss` method with a FieldError. Recover the input variables from the simplified system instead, which the operating-point extraction in the same method already does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014QR4FuuvxZU9a3UrTJjg5X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTK 11.36 removed the
inputsfield fromLinearizationFunction(replaced byinputs_getter/num_inputs), so thenamed_ss(sys, linfun::LinearizationFunction, outputs)method throws aFieldErroron any use (this is the hot path used by DyadControlSystems'get_tf).Since v2.8.0 already requires
ModelingToolkit = "11.36", the released version cannot work with any resolvable MTK, hence the patch bump to 2.8.1.Fix: recover the input variables from the simplified system via
ModelingToolkit.inputs(ssys), which the operating-point extraction a few lines below already relies on (same order assumption as before).Added a regression test exercising
linearization_function→named_ss(ssys, lin_fun, outputs). Verified against MTK 11.36.0: the new test passes, and DyadControlSystems'test_get_tf.jl(which hits this path) goes from FieldError to fully passing.🤖 Generated with Claude Code
https://claude.ai/code/session_014QR4FuuvxZU9a3UrTJjg5X